[buddypress-trac] [BuddyPress] #2023: BP_DISABLE_ADMIN_BAR should be checked for true and not just existence

[buddypress-trac at lists.automattic.com]

#2023: BP_DISABLE_ADMIN_BAR should be checked for true and not just existence
----------------------------------------+-----------------------------------
Reporter:  TobiasBg                     |       Owner:       
    Type:  enhancement                  |      Status:  new  
Priority:  minor                        |   Milestone:  1.2.1
Keywords:  has-patch reporter-feedback  |  
----------------------------------------+-----------------------------------
Changes (by cnorris23):

  * keywords:  has-patch => has-patch reporter-feedback
  * priority:  major => minor


Comment:

 The current implementation, {{{defined( 'BP_DISABLE_ADMIN_BAR' )}}}, is
 correct. The {{{BP_DISABLE_ADMIN_BAR}}} constant isn't define in the core
 BuddyPress code, and is only later defined by the user. Either in a
 plugin, their bp-custom.php, or their wp-config.php, so it's existence is
 all that needs to be checked. Whether you define it as {{{true}}},
 {{{false}}}, or {{{'ninjas'}}} :), all that matters is that it's defined.
 The recommended way to define it is set as {{{define(
 'BP_DISABLE_ADMIN_BAR', true );}}}, because that makes the most logical
 sense. Unless you can give a good use case as to why this should be
 changed, this ticket will likely be closed.

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2023#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress