[buddypress-trac] [BuddyPress] #2023: BP_DISABLE_ADMIN_BAR should be checked for true and not just existence

[buddypress-trac at lists.automattic.com]

#2023: BP_DISABLE_ADMIN_BAR should be checked for true and not just existence
------------------------+---------------------------------------------------
Reporter:  TobiasBg     |       Owner:       
    Type:  enhancement  |      Status:  new  
Priority:  major        |   Milestone:  1.2.1
Keywords:  has-patch    |  
------------------------+---------------------------------------------------
 When playing around with the constant BP_DISABLE_ADMIN_BAR (I want to add
 a more fine grained control on who sees the admin bar), I noticed that in
 all places where it is used, it is only checked whether the constant is
 defined, but not if it is actually defined as true.
 This means that
 {{{
 define( 'BP_DISABLE_ADMIN_BAR', false );
 }}}
 does not have the expected effect.

 The attached patch changes this behavior.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/2023>
BuddyPress <http://buddypress.org/>
BuddyPress