[wp-testers] Change of behaviour of smilie translations andWP-Grins

[wordpress at nazgul.nu]

Hi,

The change to the smiley system was initiated by ticket #1279, because
people wanted to be able to use RDF in their blog without it being
smilified. During this change we also fixed ticket #24444 about smilies not
showing if they were the very first thing in a post/comment.

I tried a lot of different variations but there were always smilies not
transformed that you wanted transformed or smiley-like things that were
transformed when you didn't want them to. The current setting gave me the
least false positives and false negatives of the settings I tried.

In theory the rule I implemented makes something a smiley if it meets 2 of
the following conditions (if you see different behavior, you've found a
bug):
- At the start of a line
- At the end of a line
- Starts with a whitespace
- Ends with a whitespace

Cheers,
Bas Bosman (Nazgul)



-----Original Message-----
From: wp-testers-bounces at lists.automattic.com
[mailto:wp-testers-bounces at lists.automattic.com] On Behalf Of Lloyd Budd
Sent: dinsdag 16 januari 2007 21:29
To: wp-testers at lists.automattic.com
Subject: Re: [wp-testers] Change of behaviour of smilie translations
andWP-Grins

On 1/16/07, Les Bessant <les at lcb.me.uk> wrote:
> Found this behaviour with the betas (it may precede them, but I didn't
look
> too closely before).
>
> All posts imported from my live 2.0.x installation into a test site using
> 2.1.
>
> I have a number of custom smilies, all defined in wp-config.php. As I
often
> string several together, not all their translations have spaces in. In
fact,
> hardly any do. Most are of the form ':rant:' with the surrounding colons
> being enough to ensure they are only translated when I want them to.
>
> This all works as expected in 2.0.x.
>
> In 2.1, I find that translation does not happen unless there are spaces
> around the string to be translated. So a smiley at the beginning of a
> comment tends not to be translated, two in a row don't get translated, and
> those inserted straight after words or punctuation don't get translated.
>
> I found this: http://trac.wordpress.org/ticket/2444 in trac - I'm not a
> coder, so I have little chance of working out what it means, but it looks
> like it might be related.
>
> Is this behaviour expected[1] or is it something that can be changed
>
>
>
> [1] Or "by design" as Microsoft like to say about annoying "features" ;-)

Hi Les,

By implementation ;-)

I recall Nazgul working in this area. I think that ticket resulted in
another bug.  I recall him describing it as surprisingly tricky.

Interpretting smiles:) in strings not at the start or end of a line or
surrounded by space is awkward, though of the form:rant: would
probably not be.

Cheers,
Lloyd
_______________________________________________
wp-testers mailing list
wp-testers at lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-testers