[wpmu-trac] Re: [WordPress MU Trac] #925: checks for themes & plugin updates happens too often (evey single click actually)

[WordPress MU Trac]

#925: checks for themes & plugin updates happens too often (evey single click
actually)
----------------------------+-----------------------------------------------
 Reporter:  david.chungue   |        Owner:  somebody
     Type:  defect          |       Status:  reopened
 Priority:  normal          |    Milestone:  2.7.1   
Component:  Administration  |      Version:  2.7     
 Severity:  normal          |   Resolution:          
 Keywords:                  |  
----------------------------+-----------------------------------------------
Changes (by jamescollins):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 I have just noticed that the old (incorrect) wp_x_option records aren't
 deleted.

 This isn't a major issue, but it should still be fixed.

 For example, the {{{ update_option_update_plugins }}} hook is used to try
 and delete the incorrect record if it exists, however this hook is never
 executed.

 This is because the {{{ pre_update_option_update_plugins }}} filter
 updates the sitemeta entry, then returns the old value, causing the {{{
 update_option() }}} to return false (because the new and old values are
 the same).

 This means that the {{{ update_option_update_plugins }}} hook is never
 called.

 Instead, I think we should be calling the {{{ delete_option(
 'update_plugins' ) }}} as part of the {{{ pre_update_option_update_plugins
 }}} filter.

 I'll attach a patch to correct this.

-- 
Ticket URL: <http://trac.mu.wordpress.org/ticket/925#comment:11>
WordPress MU Trac <http://mu.wordpress.org/>
WordPress Multiuser