[wpmu-trac] Re: [WordPress MU Trac] #925: checks for themes & plugin updates happens too often (evey single click actually)

WordPress MU Trac wpmu-trac at lists.automattic.com
Tue Mar 24 22:08:25 GMT 2009


#925: checks for themes & plugin updates happens too often (evey single click
actually)
----------------------------+-----------------------------------------------
 Reporter:  david.chungue   |        Owner:  somebody
     Type:  defect          |       Status:  new     
 Priority:  normal          |    Milestone:  2.7.1   
Component:  Administration  |      Version:  2.7     
 Severity:  normal          |   Resolution:          
 Keywords:  has-patch       |  
----------------------------+-----------------------------------------------
Comment (by jamescollins):

 Replying to [comment:6 donncha]:
 > jamescollins - a better way to do this is to trap the get_option and
 update_option calls with a filter/action. That's what I tried to do with
 the actions at the end of wpmu-functions.php in the 2.7 branch.

 Yes, I agree that filters would be the best way to avoid modifying core
 files, but I had noticed that {{{ update_site_option() }}} was already
 being used in {{{ wp-includes/update.php }}} in the {{{ wp_version_check()
 }}} function.

 I also hadn't noticed the changes you had checked into the 2.7 branch.


 I have just done some testing with the changes from the 2.7 branch, and
 the options are successfully saved/loaded from the wp_sitemeta table, not
 the wp_x_options table.

 Manually changing the WPMU version back to 2.6.5 correctly displays the
 core update available message, as does changing a plugin's version back.

 > Someone reported back that they didn't work though but I'd like to get
 more feedback before modifying more core files.

 What problems were specifically reported? I can't see any problems with
 the changes.

-- 
Ticket URL: <http://trac.mu.wordpress.org/ticket/925#comment:7>
WordPress MU Trac <http://mu.wordpress.org/>
WordPress Multiuser


More information about the wpmu-trac mailing list