[wpmu-trac] [WordPress MU Trac] #931: pre_update_term filter in wp_update_term causes issues with custom taxonomies as is

[WordPress MU Trac]

#931: pre_update_term filter in wp_update_term causes issues with custom
taxonomies as is
---------------------------+------------------------------------------------
 Reporter:  simonwheatley  |       Owner:  somebody
     Type:  defect         |      Status:  new     
 Priority:  normal         |   Milestone:          
Component:  component1     |     Version:  2.7.1   
 Severity:  normal         |    Keywords:          
---------------------------+------------------------------------------------
 The pre_update_term filter in wp_update_term was introduced in Changeset
 1137 to make the slug the same as the sanitised term name.

 {{{$args = apply_filters( 'pre_update_term', $term, $taxonomy, $args ); //
 MU only}}}

 While trying to make some custom taxonomy code work where I wanted to
 remove this filter (temporarily) using remove_filter. Unfortunately,
 because $args is the item being filtered, but it is not passed as the
 first argument to the filter this sets $args to the value of $term.

 I suggest that the arguments are reordered like so:

 {{{$args = apply_filters( 'pre_update_term', $args, $term, $taxonomy ); //
 MU only}}}

 Then the filter can be removed, and the value of $args is preserved
 correctly. The order of arguments in filter functions using this filter
 hook would also need to be changed.

-- 
Ticket URL: <http://trac.mu.wordpress.org/ticket/931>
WordPress MU Trac <http://mu.wordpress.org/>
WordPress Multiuser