[wpmu-trac] Re: [WordPress MU Trac] #849: add_menu_page creating different URLs in top admin bar and sidebar

[WordPress MU Trac]

#849: add_menu_page creating different URLs in top admin bar and sidebar
-------------------------------+--------------------------------------------
 Reporter:  gortsleigh         |        Owner:  somebody
     Type:  defect             |       Status:  new     
 Priority:  high               |    Milestone:  2.7     
Component:  Administration     |      Version:  2.7     
 Severity:  normal             |   Resolution:          
 Keywords:  admin menu wpabar  |  
-------------------------------+--------------------------------------------
Comment (by gortsleigh):

 The problem in URL generation appears to be an inconsistency in wp-
 includes/wordpress-admin-bar/wordpress-admin-bar.php, in function
 OutputMenuBar.  In that function, the value of the 'custom' key is checked
 only for menus that have submenus.

 The following patch may fix it, but I don't understand how the 'custom'
 key gets set, so I'm not completely confident it is correct for all cases.
 It does fix the problem for my plugin.


 {{{
 Index: wp-includes/wordpress-admin-bar/wordpress-admin-bar.php
 ===================================================================
 --- wp-includes/wordpress-admin-bar/wordpress-admin-bar.php     (revision
 1074)
 +++ wp-includes/wordpress-admin-bar/wordpress-admin-bar.php     (working
 copy)
 @@ -311,7 +311,8 @@
                                                 $first = FALSe;
                                         }

 -                                       echo '"><a href="' . admin_url(
 $topstub ) . '">' . $menu[0]['title'] . "</a></li>\n";
 +                                       $url = ( TRUE ===
 $menu[0]['custom'] ) ? 'admin.php?page=' . $topstub : $topstub;
 +                                       echo '"><a href="' . admin_url(
 $url ) . '">' . $menu[0]['title'] . "</a></li>\n";
                                 } else {
                                         echo '                  <li class
 ="wpabar-menu_';
                                         if ( TRUE === $menu[0]['custom'] )
 echo 'admin-php_';

 }}}

-- 
Ticket URL: <http://trac.mu.wordpress.org/ticket/849#comment:1>
WordPress MU Trac <http://mu.wordpress.org/>
WordPress Multiuser