[wpmu-trac] [WordPress MU Trac] #1090: Broken Attachment paths after upgrade from 2.7.1 to 2.8.4

[WordPress MU Trac]

#1090: Broken Attachment paths after upgrade from 2.7.1 to 2.8.4
-----------------------+----------------------------------------------------
 Reporter:  johnnypez  |       Owner:  somebody   
     Type:  defect     |      Status:  new        
 Priority:  high       |   Milestone:  2.8        
Component:  General    |     Version:  2.8.2      
 Severity:  normal     |    Keywords:  attachments
-----------------------+----------------------------------------------------
 After updating from MU 2.7.1 to 2.8.4 I ran into this problem where all
 attachment urls were not being create correctly. All urls included the
 full system file path.

 Upon further investigation I found that the  wp_get_attachment_url()
 method in wp-includes/post.php only takes into account the upload path
 from single user WP (wp-content/uploads)

 I patched the method to look for the mu upload directory (wp-
 content/blogs.dir) and attachment urls are being generated correctly
 again. See code below. I've attached a diff also.


 {{{
 function wp_get_attachment_url( $post_id = 0 ) {
         $post_id = (int) $post_id;
         if ( !$post =& get_post( $post_id ) )
                 return false;

         $url = '';
         global $blog_id;
         $wpmu_upload_dir = "wp-content/blogs.dir/$blog_id/files/";
         if ( $file = get_post_meta( $post->ID, '_wp_attached_file', true)
 ) { //Get attached file
                 if ( ($uploads = wp_upload_dir()) && false ===
 $uploads['error'] ) { //Get upload directory
                         if ( 0 === strpos($file, $uploads['basedir']) )
 //Check that the upload base exists in the file location
                                 $url = str_replace($uploads['basedir'],
 $uploads['baseurl'], $file); //replace file location with url location
                         elseif ( false !== strpos($file, 'wp-
 content/uploads') )
                                 $url = $uploads['baseurl'] . substr(
 $file, strpos($file, 'wp-content/uploads') + 18 );
                         elseif ( false !== strpos($file, $wpmu_upload_dir)
 )
                         $url = $uploads['baseurl'] . substr( $file,
 strpos($file, $wpmu_upload_dir) + strlen($wpmu_upload_dir) );
                         else
                                 $url = $uploads['baseurl'] . "/$file";
 //Its a newly uploaded file, therefor $file is relative to the basedir.
                 }
         }

         if ( empty($url) ) //If any of the above options failed, Fallback
 on the GUID as used pre-2.7, not recomended to rely upon this.
                 $url = get_the_guid( $post->ID );

         if ( 'attachment' != $post->post_type || empty($url) )
                 return false;

         return apply_filters( 'wp_get_attachment_url', $url, $post->ID );
 }
 }}}

-- 
Ticket URL: <http://trac.mu.wordpress.org/ticket/1090>
WordPress MU Trac <http://mu.wordpress.org/>
WordPress Multiuser