[wpmu-trac] [WordPress MU Trac] #215: Rewrite rules cause some URLs to fail

[WordPress MU Trac]

#215: Rewrite rules cause some URLs to fail
------------------------------------------------+---------------------------
 Reporter:  kipit                               |        Owner:  somebody
     Type:  defect                              |       Status:  reopened
 Priority:  highest                             |    Milestone:  2.8     
Component:  General                             |      Version:  2.8     
 Severity:  normal                              |   Resolution:          
 Keywords:  rewriterule htaccess loop redirect  |  
------------------------------------------------+---------------------------
Changes (by brodock):

  * version:  2.7 => 2.8
  * milestone:  2.7.1 => 2.8


Comment:

 I've found a solution to the problem. This rule:

 {{{
 RewriteRule  ^([_0-9a-zA-Z-]+/)?(wp-.*) $2 [L]
 RewriteRule  ^([_0-9a-zA-Z-]+/)?(.*\.php)$ $2 [L]
 }}}

 Looks like to be wrong writen, i will explain:
 This rule was created to catch URLs like: http://domain.tdl/myblog/wp-
 content/themes/images/logo.png and do an internal redirect to wp-
 content/themes/images/logo.png removing "myblog".

 The problem is that after this rewrite is executed, it will pass through
 all rules again, and as this piece of the regular expression ^([_0-9a-
 zA-Z-]+/) can be ignored because of the use of '?' (none or one) it will
 match again the second part: (wp-.*) $2 [L] and do another redirect that
 will cause another passing through the rules.

 This will cause an infinite loop and a 500 error on the server, if the
 file doesn't exist.

 This problem doesn't happen if file exists because of this rule that
 precedes the wrong one:

 {{{
 RewriteCond %{REQUEST_FILENAME} -f [OR]
 RewriteCond %{REQUEST_FILENAME} -d
 RewriteRule . - [L]
 }}}

 That basically "stops" rewrite rules if file exists.

 the same happens with:

 {{{
 RewriteRule  ^([_0-9a-zA-Z-]+/)?(.*\.php)$ $2 [L]
 }}}

 so i propouse to change:

 {{{
 RewriteRule  ^([_0-9a-zA-Z-]+/)?(wp-.*) $2 [L]
 RewriteRule  ^([_0-9a-zA-Z-]+/)?(.*\.php)$ $2 [L]
 }}}

 to this to:

 {{{
 RewriteRule  ^([_0-9a-zA-Z-]+/)(wp-.*) $2 [L]
 RewriteRule  ^([_0-9a-zA-Z-]+/)(.*\.php)$ $2 [L]
 }}}

 to stop the 500 loop

-- 
Ticket URL: <http://trac.mu.wordpress.org/ticket/215#comment:16>
WordPress MU Trac <http://mu.wordpress.org/>
WordPress Multiuser