[wpmu-trac] Re: [WordPress MU Trac] #524: Make wpmu_welcome_notification and wpmu_welcome_user_notification pluggable

[WordPress MU Trac]

#524: Make wpmu_welcome_notification and wpmu_welcome_user_notification pluggable
-------------------------+--------------------------------------------------
 Reporter:  axelseaa     |        Owner:  somebody
     Type:  enhancement  |       Status:  reopened
 Priority:  normal       |    Milestone:          
Component:  component1   |      Version:          
 Severity:  normal       |   Resolution:          
 Keywords:               |  
-------------------------+--------------------------------------------------
Changes (by Haller):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 {{{
 if( !apply_filters('wpmu_signup_blog_notification', $domain, $path,
 $title, $user, $user_email, $key, $meta) )
         return;
 }}}


 I'm afraid this won't do the trick.

 The method apply_filters($tag, $string) accepts only one string. So from
 the above code only the variable domain will be available and $path,
 $title, $user, $user_email, $key, $meta won't be. This makes it impossible
 to override the method since you don't have all the information.

 I think it should be like this:

 {{{
 if( !apply_filters('wpmu_signup_blog_notification',
 array("domain"=>$domain, "path"=>$path, "title"=>$title, "user"=>$user,
 "user_email"=>$user_email, "key"=>$key, "meta"=>$meta)) )
         return;
 }}}

-- 
Ticket URL: <http://trac.mu.wordpress.org/ticket/524#comment:4>
WordPress MU Trac <http://mu.wordpress.org/>
WordPress Multiuser