[wp-trac] [WordPress Trac] #65160: Misleading error message on user screen actions, if no role has been selected

[WordPress Trac]

#65160: Misleading error message on user screen actions, if no role has been
selected
--------------------------+------------------------------
 Reporter:  Presskopp     |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Users         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  ui
--------------------------+------------------------------

Comment (by hbhalodia):

 Hi @Presskopp,

 I’m not entirely sure what the exact issue is here, as the current wording
 looks correct to me. I reviewed the following test cases, and all of them
 appear to behave as expected without showing misleading messages.

 Could you please review the cases below and clarify what specifically
 needs to be updated? Once clarified, we can also check with the wider team
 to determine whether other users feel the wording should be changed.

 1. No bulk action selected, no role change selected, no users selected —
 Click **Apply**
     - Message: `Please select a bulk action to perform.` — Does not appear
 misleading.
 2. No bulk action selected, no role change selected, no users selected —
 Click **Change**
     * Message: `Please select a bulk action to perform.` — Does not appear
 misleading.
 3. No bulk action selected, no role change selected, users selected —
 Click **Apply**
     * Message: `Please select a bulk action to perform.` — Does not appear
 misleading.
 4. No bulk action selected, no role change selected, users selected —
 Click **Change**
     * Message: `Please select a bulk action to perform.` — Does not appear
 misleading.
 5. Password Reset bulk action selected, no role change selected, no users
 selected — Click **Apply**
     * Message: `Please select at least one item to perform this action
 on.` — Does not appear misleading.
 6. Password Reset bulk action selected, no role change selected, no users
 selected — Click **Change**
     * Message: `Please select a bulk action to perform.` — Does not appear
 misleading, as no role change was selected.
 7. Password Reset bulk action selected, no role change selected, users
 selected — Click **Apply**
     * Message: `Password reset links sent to n users.` — Does not appear
 misleading.
 8. Password Reset bulk action selected, no role change selected, users
 selected — Click **Change**
     * Message: `Please select a bulk action to perform.` — Does not appear
 misleading, as no role change was selected.
 9. No bulk action selected, Subscriber role selected, no users selected —
 Click **Apply**
     * Message: `Please select a bulk action to perform.` — Does not appear
 misleading.
 10. No bulk action selected, Subscriber role selected, no users selected —
 Click **Change**
     * Message: `Please select at least one item to perform this action
 on.` — Does not appear misleading.
 11. No bulk action selected, Subscriber role selected, users selected —
 Click **Apply**
     * Message: `Please select a bulk action to perform.` — Does not appear
 misleading, as the role change option was selected but the bulk action
 button was clicked.
 12. No bulk action selected, Subscriber role selected, users selected —
 Click **Change**
     * Message: `Changed roles.` — Does not appear misleading.
 13. Password Reset bulk action selected, Subscriber role selected, no
 users selected — Click **Apply**
     * Message: `Please select at least one item to perform this action
 on.` — Does not appear misleading.
 14. Password Reset bulk action selected, Subscriber role selected, no
 users selected — Click **Change**
     * Message: `Please select at least one item to perform this action
 on.` — Does not appear misleading.
 15. Password Reset bulk action selected, Subscriber role selected, users
 selected — Click **Apply**
     * Message: `Password reset links sent to n users.` — Does not appear
 misleading.
 16. Password Reset bulk action selected, Subscriber role selected, users
 selected — Click **Change**
     * Message: `Changed roles.` — Does not appear misleading.

 I believe I have covered all possible cases, and I do not currently see
 any misleading messages. The only scenario that may be worth reconsidering
 is when users click **Change** or **Apply** without making any selection,
 as both currently display the same message:

 `Please select a bulk action to perform.`

 Perhaps when clicking **Change**, the message could instead be something
 like:

 `Please select a role to change.`

 That is the only potential improvement I can currently identify.

 Thanks,

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/65160#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform