[wp-trac] [WordPress Trac] #29798: unified theme and plugin uploader

[WordPress Trac]

#29798: unified theme and plugin uploader
--------------------------------------+-----------------------------
 Reporter:  svenl77                   |       Owner:  (none)
     Type:  feature request           |      Status:  new
 Priority:  normal                    |   Milestone:  Future Release
Component:  General                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch good-first-bug  |     Focuses:  administration
--------------------------------------+-----------------------------
Changes (by gaisma22):

 * keywords:  has-patch good-first-bug needs-testing => has-patch good-
     first-bug


Comment:

 == Patch Testing Report

 Patch Tested: https://github.com/WordPress/wordpress-develop/pull/8913

 === Environment
 - WordPress: 7.0-beta6-62085-src
 - PHP: 8.3.30
 - Server: nginx/1.29.7
 - Database: MySQL 8.4.8
 - Browser: Brave
 - OS: Ubuntu
 - Theme: Twenty Twenty-Five 1.4
 - MU Plugins: None
 - Plugins: None

 === Steps taken
 1. Uploaded **hello-dolly.zip** via Appearance -> Themes
    -> Add New Theme -> Upload Theme.
    **Before patch:** "The theme is missing the style.css
    stylesheet." No helpful link.
 2. Uploaded **twentytwentyfive.zip** via Plugins -> Add
    New -> Upload Plugin.
    **Before patch:** "No valid plugins were found.
    Go to Plugin Installer" - link already present.
 3. Applied patch from PR #8913.
 4. Repeated step 1 - **after patch:** "This appears to
    be a plugin package. Go to the Plugin Installer."
 5. Repeated step 2 - **after patch:** "This appears to
    be a theme package. Go to the Theme Installer."
 ✅ Patch is solving the problem

 === Expected result
 When a plugin zip is uploaded to the theme uploader or a theme zip to the
 plugin uploader, WordPress should show a helpful message with a link to
 the correct installer.

 === Additional Notes
 1. Bug confirmed on WordPress 7.0-beta6 - uploading
    a plugin zip to the theme uploader showed a
    confusing error with no helpful link.
 2. Theme zip in plugin uploader already showed
    "Go to Plugin Installer" before the patch. After
    the patch it also shows "Go to Theme Installer".
 3. Removing **`needs-testing`** as patch resolves the issue on WordPress
 7.0-beta6-62085-src.

 === Screenshots/Screencast with results

 **Before Patch:**

 [[Image(https://i.ibb.co/4g79JzbV/before-plugin-as-theme.png)]]

 [[Image(https://i.ibb.co/vCpM3d0K/before-theme-as-plugin.png)]]

 **After Patch:**

 [[Image(https://i.ibb.co/gZNMCXGT/after-plugin-as-theme.png)]]

 [[Image(https://i.ibb.co/fz1qzxFz/after-theme-as-plugin.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/29798#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform