[wp-trac] [WordPress Trac] #64957: Connectors: `WP_Connector_Registry::register()` ignores custom `setting_name`

[WordPress Trac]

#64957: Connectors: `WP_Connector_Registry::register()` ignores custom
`setting_name`
------------------------------------+-------------------------------
 Reporter:  jorgefilipecosta        |       Owner:  jorgefilipecosta
     Type:  defect (bug)            |      Status:  closed
 Priority:  high                    |   Milestone:  7.0
Component:  General                 |     Version:  trunk
 Severity:  normal                  |  Resolution:  fixed
 Keywords:  has-patch dev-reviewed  |     Focuses:
------------------------------------+-------------------------------
Changes (by jorgefilipecosta):

 * owner:  (none) => jorgefilipecosta
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"62116" 62116]:
 {{{
 #!CommitTicketReference repository="" revision="62116"
 Connectors: Respect custom `setting_name` in connector registration.

 `WP_Connector_Registry::register()` always auto-generates the
 `setting_name`
 for connectors with `api_key` authentication, ignoring any caller-provided
 value. This prevents connectors from using existing WordPress options as
 their
 API key storage.
 This change checks for a non-empty `setting_name` in the provided args
 before
 falling back to the auto-generated name.

 Props jorgefilipecosta, gziolo.
 Fixes #64957.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64957#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform