[wp-trac] [WordPress Trac] #64904: Real time collboration: determine approach for opt in setting for users in Settings > Writing

[WordPress Trac]

#64904: Real time collboration: determine approach for opt in setting for users in
Settings > Writing
-------------------------------------------+---------------------
 Reporter:  annezazu                       |       Owner:  (none)
     Type:  task (blessed)                 |      Status:  new
 Priority:  normal                         |   Milestone:  7.0
Component:  General                        |     Version:  trunk
 Severity:  normal                         |  Resolution:
 Keywords:  needs-design has-patch commit  |     Focuses:  ui
-------------------------------------------+---------------------

Comment (by zieladam):

 In [changeset:"62100" 62100]:
 {{{
 #!CommitTicketReference repository="" revision="62100"
 Real-Time Collaboration: Define WP_ALLOW_COLLABORATION in
 wp_is_collaboration_allowed()

 #62075 introduced the WP_ALLOW_COLLABORATION constant to help hosts
 disable RTC at the platform level. The constant was defined in
 wp_functionality_constants(), which runs in wp-settings.php after
 collaboration.php is loaded. That created a boot-order edge case where
 wp_is_collaboration_enabled() could be called before the constant existed
 – for instance via SHORTINIT.

 This commit moves the constant definition into a new
 wp_is_collaboration_allowed() function in collaboration.php. The function
 checks the constant, and if it's missing, defines it on the spot from the
 environment variable (defaulting to true). wp_is_collaboration_enabled()
 now delegates to wp_is_collaboration_allowed() for the constant check, and
 the admin UI calls wp_is_collaboration_allowed() directly to decide
 whether to show the checkbox or a "disabled" notice. It also slightly
 improves the label of the "enable RTC" checkbox on the settings page.


 Props peterwilsoncc, mcsf, joen, ingeniumed.

 Developed in https://github.com/WordPress/wordpress-develop/pull/11333.

 See #64904.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64904#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform