[wp-trac] [WordPress Trac] #64882: Twenty Fourteen's "featured" tag is being removed from posts

[WordPress Trac]

#64882: Twenty Fourteen's "featured" tag is being removed from posts
---------------------------+-----------------------------
 Reporter:  poena          |      Owner:  (none)
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Bundled Theme  |    Version:
 Severity:  normal         |   Keywords:  needs-patch
  Focuses:                 |
---------------------------+-----------------------------
 Original issue: https://github.com/WordPress/gutenberg/issues/8544

 Reported in 2018:


 When used with the Twenty Fourteen theme, Gutenberg removes the featured
 tag that makes posts show up in the home page's Featured Content section.
 Attempts to re-add the featured tag result in new tags called featured,
 but with slugs such as featured-2 and featured-3, so that the posts still
 do not appear in Featured Content.

 A workaround would appear to be to change the featured content tag name
 (in Customizer/Featured Content/Tag Name) to anything else and then to
 change it back to featured.

 To Reproduce
 Steps to reproduce the behavior:
 Install WordPress 4.9.8 on development server.
 Install and activate Twenty Fourteen theme (v2.2).
 Create three posts, each with several tags, among which is featured.
 The posts will now be visible in Featured Content on the Home Page.
 Install the Gutenberg plugin.
 In the Gutenberg editor, the featured tag will now be invisible. If each
 post is saved, it will lose its featured tag and status, disappearing from
 Featured Content.
 If one attempts to re-add the featured tag inside the Gutenberg editor, a
 new tag named featured will be created with the slug featured-2, so that
 the post will not appear in Featured Content. Further attempts will result
 in featured-3, featured-4, etc.
 Expected behavior
 From the point of view of the Gutenberg editor, featured should just be a
 tag like any other. As far as I know, it's Twenty Fourteen that treats it
 as being special, and even that can be adjusted.
 Additional context
 Gutenberg v3.4.0

 ----

 Today, Gutenberg does not have to be active for this problem to appear.


 == Testing instructions:
 Install and activate Twenty Fourteen theme.
 Create a post and add a tag called featured. See how when you save, this
 tag is not visible in the field in the block editor.
 Save the post and view the homepage. Confirm that the post does **not**
 show at the top of the page, just below the header, with a black
 background (or featured image). Instead, it shows among the other posts in
 the blog.



 == Suggested solution:
 In twentyfourteen\inc\featured-content.php, inside {{{public static
 function hide_the_featured_term}}}
 locate:

 {{{
 // This filter is only appropriate on the front end.
 if ( is_admin() ) {
 return $terms;
 }
 }}}

 And change it to

 {{{
 // This filter is only appropriate on the front end.
 if ( is_admin() || wp_is_serving_rest_request() ) {
 return $terms;
 }
 }}}
 Test again and confirm that the post is now featured.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64882>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform