[wp-trac] [WordPress Trac] #64763: Admin reskin: Remove line-height from input elements

[WordPress Trac]

#64763: Admin reskin: Remove line-height from input elements
-------------------------------------------------+-------------------------
 Reporter:  wildworks                            |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  7.0
Component:  Administration                       |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  admin-reskin good-first-bug has-     |     Focuses:
  patch changes-requested                        |
-------------------------------------------------+-------------------------
Changes (by r1k0):

 * keywords:  admin-reskin good-first-bug has-patch => admin-reskin good-
     first-bug has-patch changes-requested


Comment:

 == Patch Testing Report

 Patch Tested: https://github.com/WordPress/wordpress-develop/pull/11246

 === Environment
 - WordPress: 7.0-beta5-61991-src
 - PHP: 8.3.30
 - Server: nginx/1.29.5
 - Database: mysqli (Server: 8.4.8 / Client: mysqlnd 8.3.30)
 - Browser: Chrome 146.0.0.0
 - OS: Windows 10/11
 - Theme: Twenty Twenty-Five 1.4
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.1

 === Steps taken
 1. Head over to **Pages > All pages**.
 2. Enter text into the search input field, then highlight the text.
 3. Observe the height of the highlight.
 4. ❌ Patch is not entirely solving the problem.

 5. Bonus: Check the height of the highlight background for the input
 fields, which I have listed in the additional notes section. Also, feel
 free to check other input fields around the admin dashboard.

 === Expected result
 - The highlight background should have a shorter height meant to fit the
 highlighted text.

 === Additional Notes
 - While the patch fixes the highlight height of the search input field in
 the **Pages** page and multiple other places. It still doesn't fix the
 highlight height for several other input fields.

 > As mentioned here, there's probably more than one thing that needs to be
 fixed. Let's try to investigate as much as possible where this problem is
 occurring.

 - As noted above, multiple input fields need to be fixed.  Thus, updating
 keywords to let @arkaprabhachowdhury make the necessary changes.

 - When you remove the `line-height` for the **Custom time & date format**
 input field, the input field changes its height slightly. This makes the
 border top & bottom too close to the text. I suggest changing the min-
 height value to `min-height: 26px;`.

 - Find screenshots of some of the other input fields that need to be fixed
 in the Support Content section.

 - These input fields need to be fixed as well:
 ||=  Page  =||=  Input-Fields  =||
 || Add Plugin || Search Plugins ||
 || Add Theme || Search Themes ||
 || Comment(Quick Edit) || Name ||
 ||  || Email ||
 ||  || URL ||
 || All Pages(Quick Edit) || Title ||
 ||  || Slug ||
 ||  || Order ||
 ||  || Password ||
 || All Posts(Quick Edit) || Title ||
 ||  || Slug ||
 ||  || Password ||
 || Tags & Categories(Quick Edit) || Name ||
 ||  || Slug ||
 || Media Library || Search Media ||
 || Dashboard (Events widget) || City search ||
 || Settings > General || Time/Date Format (custom) ||



 === Screenshots/Screencast with results
 Page search before:
 [[Image(https://i.ibb.co/VpYb75qG/search-pages-before.png)]]

 Page search after:
 [[Image(https://i.ibb.co/HT5Q9LwP/search-pages-after.png)]]

 === Support Content
 - Here are supporting screenshots that show input fields that also need to
 be fixed.
 Media search input field:
 [[Image(https://i.ibb.co/Y7sn95x9/media-search.png)]]

 Page quick edit title input field:
 [[Image(https://i.ibb.co/yFwzy5Fb/page-title.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64763#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform