[wp-trac] [WordPress Trac] #64603: get_block_wrapper_attributes: id and aria-label should not be merged

[WordPress Trac]

#64603: get_block_wrapper_attributes: id and aria-label should not be merged
--------------------------------------+---------------------
 Reporter:  wildworks                 |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  7.0
Component:  Editor                    |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by r1k0):

 == Patch Testing Report

 Patch Tested: https://github.com/WordPress/wordpress-develop/pull/10922

 === Environment
 - WordPress: 7.0-beta4-61919-src
 - PHP: 8.3.30
 - Server: nginx/1.29.5
 - Database: mysqli (Server: 8.4.8 / Client: mysqlnd 8.3.30)
 - Browser: Chrome 145.0.0.0
 - OS: Windows 10/11
 - Theme: Twenty Twenty-Five 1.4
 - MU Plugins: None activated
 - Plugins:
   * Block Development Examples - Block Dynamic Rendering 64756b 0.1.0
   * Test Reports 1.2.1

 === Steps taken
 1. Download this dynamic block plugin https://github.com/WordPress/block-
 development-examples/releases/download/latest/block-dynamic-rendering-
 64756b.zip from [https://github.com/WordPress/block-development-examples
 WordPress block-development-examples].
 2. Upload the plugin and activate it.
 3. Head over to the plugin files, and add this code to the
 `build/block.json` under the `"example": {},`
 {{{
   "attributes": {
           "anchor": {
                   "type": "string"
           }
   },
 }}}
 4. In the same file, add `"anchor": true` inside the support object then
 save the file.
 5. Edit the `build/render.php` file and add this code just above the `<p>`
 tag
 {{{
 <?php
 $block_wrapper_attributes = get_block_wrapper_attributes( [
         'id'         => $attributes[ 'anchor' ],
 ] );

 ?>
 }}}
 6. In the same file, remove `get_block_wrapper_attributes()` in the `<p>`
 tag and add `$block_wrapper_attributes`. In the end it should look like
 this, then save the file.
 {{{
 <p <?php echo wp_kses_data( $block_wrapper_attributes  ); ?>>
         <?php esc_html_e( 'Block with Dynamic Rendering – hello!!!',
 'block-development-examples' ); ?>
 </p>
 }}}
 7. Head over to your dashboard, and add a new post.
 8. In the editor, add the **Block Dynamic Rendering** block.
 9. Add `my-anchor` in **HTML anchor** input field, save the post and view
 the post in the frontend.
 10. Inspect the paragraph added by the block.
 11. ✅ Patch is solving the problem

 === Expected result
 - The `id` should only hold one value and not an original and a duplicate.

 === Additional Notes
 - I wasn't able to get merged values when it came to `aria-label`.
 === Screenshots/Screencast with results
 Before:
 [[Image(https://i.ibb.co/zhm5QmBH/attr-before.png)]]

 After:
 [[Image(https://i.ibb.co/MxQCmX66/attr-after.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64603#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform