[wp-trac] [WordPress Trac] #63980: Set featured image button incorrectly coded as link and missing required ARIA attributes

[WordPress Trac]

#63980: Set featured image button incorrectly coded as link and missing required
ARIA attributes
--------------------------------------------+------------------------------
 Reporter:  alh0319                         |       Owner:  joedolson
     Type:  defect (bug)                    |      Status:  closed
 Priority:  normal                          |   Milestone:  7.0
Component:  Editor                          |     Version:
 Severity:  normal                          |  Resolution:  fixed
 Keywords:  has-patch has-test-info commit  |     Focuses:  ui,
                                            |  accessibility
--------------------------------------------+------------------------------

Comment (by famyra98):

 Replying to :
 > == Patch Testing Report
 >
 > Patch Tested: {{{https://github.com/WordPress/wordpress-
 develop/pull/10885"}}}
 >
 > === Environment
 > * WordPress: 7.0-alpha-61215-src
 > * PHP: 8.2.x
 > * Browser: Chrome (macOS)
 > * OS: macOS
 > * Theme: Twenty Twenty-Five
 > * Plugins:
 >   * Classic Editor
 >
 > === Steps Taken
 >
 > 1. Installed and activated the Classic Editor plugin.
 > 2. Navigated to Posts → Add New.
 > 3. Located the "Set Featured Image" metabox.
 > 4. Used the `Tab` key to focus the "Set featured image" control.
 > 5. Tested activation using:
 >    * Enter key
 >    * Spacebar
 > 6. Repeated testing before and after applying the patch.
 > 7. Verified screen reader output for role and dialog announcement.
 > 8. Repeated tests for "Remove featured image" after setting an image.
 > 9. ✅ Patch is solving the problem.
 >
 > Before patch:
 > * Activates only when pressing Enter.
 > * Spacebar does not trigger the control.
 > * No indication that activating the control opens a dialog.
 >
 > After patch:
 > * Control is announced as a "button".
 > * Screen readers report it as having a popup of type "dialog".
 > * Both Enter and Spacebar trigger the media modal.
 > * Holding Spacebar, pressing Tab, and releasing Spacebar does NOT
 trigger the control (correct key handling).
 > * "Remove featured image" control behaves consistently.
 > * Behavior matches expected results.
 >
 > === Screenshots / Screencast
 >
 > Before: https:/files.catbox.moe/jluavh.mp4
 >
 > After: [[Image(https://shortu.me/442b4k)]]
 >

 As I see the full results shown on the screencast, the issue appears
 resolved after the patch: the control is correctly announced as a button
 with a dialog popup, Enter and Spacebar trigger the media modal, keyboard
 handling works as expected, and the “Remove featured image” control
 behaves consistently. Thank you.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63980#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform