[wp-trac] [WordPress Trac] #64825: Twenty Seventeen: twentyseventeen_edit_link() function passed

[WordPress Trac]

#64825: Twenty Seventeen: twentyseventeen_edit_link() function passed
---------------------------+--------------------------
 Reporter:  westonruter    |       Owner:  westonruter
     Type:  defect (bug)   |      Status:  assigned
 Priority:  normal         |   Milestone:  7.0
Component:  Bundled Theme  |     Version:  4.7
 Severity:  minor          |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+--------------------------

Comment (by sabernhardt):

 Removing the parameter from page content templates should have very low
 risk, but that is higher than zero.

 With the attached child theme:
 - Single post and any archive (including blog and front page of posts)
 templates would already require adjustments to template files if a custom
 `twentyseventeen_edit_link()` requires a parameter. If the site has pages
 without any posts, that could avoid the errors, but then why would someone
 create a replacement function with a parameter?
 - The single page template and static front page (with or without page
 panels) would start to throw PHP fatal errors with PR 11209, unless those
 templates are also included in the child theme with a parameter.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64825#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform