[wp-trac] [WordPress Trac] #64824: User is completely unable to edit content when `wp_enable_real_time_collaboration` is missing from `wp_options`

[WordPress Trac]

#64824: User is completely unable to edit content when
`wp_enable_real_time_collaboration` is missing from `wp_options`
--------------------------+-----------------------
 Reporter:  desrosj       |       Owner:  desrosj
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  7.0
Component:  Editor        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  commit        |     Focuses:
--------------------------+-----------------------
Changes (by desrosj):

 * keywords:   => commit
 * owner:  (none) => desrosj
 * status:  new => assigned


Comment:

 @dlh Good catch! I'd bet that is what's causing this lock-out behavior.

 It took me a minute to spot the second filter. For anyone else looking,
 `filter_default_option()` is hooked at the end of `register_setting()`.

 I'm going to commit the `$db_version` bump now because that fixes the edge
 cases that I outlined above. The absence of
 `wp_enable_real_time_collaboration` and what the correct filter
 hooks/values should be will need a bit more discussion.

 Thinking this through, the options seem to be:
 - Switching the `$default` in the `register_setting()` to `true` I believe
 this would end up overriding a `false`/off value from some combination of
 removing the default hook/an earlier hooked function.
 - Removing the filter in `default-filters.php` would probably cause more
 edge cases where no value is returned at all or the feature is
 unexpectedly off by default.
 - Remove the `default` from `register_setting()` entirely.

 The last option seems like it may be the best choice because it would
 always fall back to `true` when the option is not present at all. @dlh Did
 you arrive at that path forward as well?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64824#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform