[wp-trac] [WordPress Trac] #64797: Admin Reskin: Primary disabled button should have visible border

[WordPress Trac]

#64797: Admin Reskin: Primary disabled button should have visible border
------------------------------------+---------------------
 Reporter:  wildworks               |       Owner:  (none)
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  7.0
Component:  Administration          |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  admin-reskin has-patch  |     Focuses:
------------------------------------+---------------------

Comment (by wildworks):

 To be safe, it's a good idea to check all button variations.

 Below is the code to add a menu page to test as many variations as
 possible.

 {{{
 #!php
 function test_add_button_variations() {
         add_menu_page(
                 'Button Variations',
                 'Button Variations',
                 'manage_options',
                 'test-button-variations',
                 'test_render_button_variations_page',
                 'dashicons-editor-table',
                 61
         );
 }
 add_action( 'admin_menu', 'test_add_button_variations' );

 function test_render_button_variations_page() {
         $variations = array(
                 'button button-primary'                  => 'Primary',
                 'button button-primary button-compact'   => 'Primary
 Compact',
                 'button button-primary button-small'     => 'Primary
 Small',
                 'button button-primary button-large'     => 'Primary
 Large',
                 'button button-primary button-hero'      => 'Primary
 Hero',
                 'button button-secondary'                => 'Secondary',
                 'button button-secondary button-compact' => 'Secondary
 Compact',
                 'button button-secondary button-small'   => 'Secondary
 Small',
                 'button button-secondary button-large'   => 'Secondary
 Large',
                 'button button-secondary button-hero'    => 'Secondary
 Hero',
                 'button-link'                            => 'Link',
                 'button-link button-link-delete'         => 'Link Delete',
         );
         $background_colors = array(
                 '#f0f0f1' => 'Default',
                 '#ffffff' => 'White',
         );
         ?>
         <div class="wrap wp-core-ui">
                 <?php foreach ( $background_colors as $background_color =>
 $background_color_label ) : ?>
                         <div style="background-color: <?php echo esc_attr(
 $background_color ); ?>;">
                                 <div style="display:flex;flex-
 wrap:wrap;gap:1em;align-items:flex-start;padding:3em;">
                                         <?php foreach ( $variations as
 $variation => $variation_label ) : ?>
                                                 <button type="button"
 class="<?php echo esc_attr( $variation ); ?>">
                                                         <?php echo
 esc_html( $variation_label ); ?>
                                                 </button>
                                         <?php endforeach; ?>
                                 </div>
                                 <div style="display:flex;flex-
 wrap:wrap;gap:1em;align-items:flex-start;padding:3em;">
                                         <?php foreach ( $variations as
 $variation => $variation_label ) : ?>
                                                 <button type="button"
 class="<?php echo esc_attr( $variation ); ?>" disabled>
                                                         <?php echo
 esc_html( $variation_label ); ?> Disabled
                                                 </button>
                                         <?php endforeach; ?>
                                 </div>
                         </div>
                 <?php endforeach; ?>
         </div>
         <?php
 }
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64797#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform