[wp-trac] [WordPress Trac] #64662: Add TypeScript static analysis for core JavaScript files

[WordPress Trac]

#64662: Add TypeScript static analysis for core JavaScript files
-----------------------------------------+--------------------------
 Reporter:  westonruter                  |       Owner:  westonruter
     Type:  task (blessed)               |      Status:  reopened
 Priority:  normal                       |   Milestone:  7.0
Component:  Build/Test Tools             |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch changes-requested  |     Focuses:  javascript
-----------------------------------------+--------------------------
Changes (by desrosj):

 * keywords:  has-patch => has-patch changes-requested
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Thanks for this, everyone!

 I have a few small points of feedback for a follow up commit. Can the
 reusable workflow file be renamed to include a `-v1` suffix? Initially
 only the PHPUnit reusable workflow contained the `-v1` suffix, but all new
 ones introduced since then have included it.

 I know it's inconsistent, but I would like to update all the others
 eventually. It's just a pain to backport to every single branch calling
 the file. I do plan to try and tackle that the next time a given workflow
 requires a new `-v2` file.

 It just makes it more apparent which one is the most recent. It's
 reasonable to assume that the file without any suffix is the current or
 active version and all with a suffix are old.

 {{{
 ( github.event_name == 'pull_request' && github.actor != 'dependabot[bot]'
 )
 }}}
 Can we remove the `dependabot` check here? The bot was deactivated in
 [61049] because it stopped working when GitHub switched over to their new
 runner architecture, and all bot specific checks were removed in [61050].

 If we ever decide to try and get that working again, we can re-add this
 check with the others.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64662#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform