[wp-trac] [WordPress Trac] #64775: Warning from pluck function on some random pages

[WordPress Trac]

#64775: Warning from pluck function on some random pages
-------------------------------------------------+-------------------------
 Reporter:  gautammkgarg                         |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:
Component:  General                              |     Version:  4.7
 Severity:  normal                               |  Resolution:  duplicate
 Keywords:  has-patch needs-unit-tests           |     Focuses:
  reporter-feedback                              |
-------------------------------------------------+-------------------------

Comment (by gautammkgarg):

 Thanks @siliconforks for investigating this issue further and providing
 more detailed steps to replicate the issue.

 Replying to [comment:9 siliconforks]:
 > It looks like this issue is specific to the Angell EYE Updater plugin.
 It adds a `pre_set_site_transient_update_plugins` filter to modify the
 `update_plugins` transient, and when it does this it creates an object
 which has only a `slug` property (and therefore it has no `plugin`
 property, so you end up getting the warning `Undefined property:
 stdClass::$plugin`):

 Good observation. It looks like the issue is due to wrong code of "Angell
 Eye Update" plugin because most of the plugins are not triggering this
 warning.

 It's not under WordPress' control how developers write the code for their
 plugins or theme. But the warning which we get in the logs or screen is
 making user confused. With the error message, it's difficult to understand
 if the issue is at WordPress' end or at Plugin's/Theme's end.

 We can trigger the warning even by executing this code
 {{{#!php
 wp_list_pluck([
         (object)[]
 ], 'any_key');
 }}}

 Looks like the other similar ticket
 (https://core.trac.wordpress.org/ticket/59774) is currently on paused
 status.

 In my opinion, the suggestions by @westonruter should be merged, as this
 will handle the warning without impacting the existing functionality.

 1. https://github.com/WordPress/wordpress-
 develop/pull/11115/changes/91716f77cb3226721f508341c7cf6ab949e98d80

 2. https://github.com/WordPress/wordpress-
 develop/pull/11115/changes/31a638613ca0cc79ff9beb674cc9130969d7f193

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64775#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform