[wp-trac] [WordPress Trac] #64393: Change how we include Gutenberg in Core

[WordPress Trac]

#64393: Change how we include Gutenberg in Core
------------------------------+--------------------------
 Reporter:  youknowriad       |       Owner:  youknowriad
     Type:  task (blessed)    |      Status:  reopened
 Priority:  high              |   Milestone:  7.0
Component:  Build/Test Tools  |     Version:
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------------

Comment (by peterwilsoncc):

 @youknowriad I've created a test repo that includes only the build
 changes, ie without commits to wp-dev that are unrelated in the mean time.
 A comparison of the before and after changes can be seen at
 [https://github.com/peterwilsoncc/wp-build-changes-
 testing/compare/667a28d4877f1ef5bbed3a2fb3b9bf1378169915...main
 peterwilsoncc/wp-build-changes-testing at 667a28d...main]. I'm updating this
 manually each morning Australian time.

 * The *.map files are still being committed to the build, these will need
 to be removed as they're not referenced in the generated files & the
 references are to uncommitted code.
 * The auto generated functions introduced in
 [https://github.com/WordPress/gutenberg/pull/73877 GB#73877] will need to
 be correctly prefixed with `wp_` - eg
 `font_library_wp_admin_render_page()`
 * These auto generated files are also very difficult to review
 * A new `index.php` files has been introduced `wp-
 includes/build/routes/index.php` - it would be good to avoid this as we've
 had issues with using index file names in the past, see #60237.
 * I'm seeing a few package.json files, eg `wp-
 includes/build/routes/navigation/package.json`
 * `wp_register_development_scripts()` has been removed without been
 deprecated
 * The global variables in `wp-includes/build/routes.php` are unprefixed.
 It also adds actions in such a way that's it's not possible for third
 party devs to remove them

 These changes also make it very unclear what PHP changes are been
 introduced. This is a problem as there are often issues picked up during
 the merge of packages to core. Package bumps will need to provide a diff
 that can be reviewed for the build effects.

 There's a lot going on in these changes so it's probable that I am missing
 a few things.


 We'll also need to consider whether `gitignore` and SVN props will need to
 be backported to branches receiving security updates to avoid the
 accidental commit of the gutenberg repo in to wp-dev.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64393#comment:58>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform