[wp-trac] [WordPress Trac] #64393: Change how we include Gutenberg in Core

[WordPress Trac]

#64393: Change how we include Gutenberg in Core
------------------------------+--------------------------
 Reporter:  youknowriad       |       Owner:  youknowriad
     Type:  task (blessed)    |      Status:  reopened
 Priority:  high              |   Milestone:  7.0
Component:  Build/Test Tools  |     Version:
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------------

Comment (by desrosj):

 I've spotted an issue just now with how the build server is committing
 updates to files generated by the new build script steps.

 It seems that the build server adds and changes files as expected, but it
 never deletes files that are removed. I believe that this is caused by the
 fact that the files in question were committed to version control prior to
 [61476], which adjusted the `svn:ignore` rules to exclude the `wp-
 includes/blocks` and `wp-includes/build` dircetories (which is where the
 majority of the issues are.

 Here is a list of files that I see present that should have been removed
 from the build server:

 {{{
 wp-includes/blocks/archives/editor-rtl.css
 wp-includes/blocks/archives/editor-rtl.min.css
 wp-includes/blocks/archives/editor.css
 wp-includes/blocks/archives/editor.min.css
 wp-includes/blocks/tag-cloud/editor-rtl.css
 wp-includes/blocks/tag-cloud/editor-rtl.min.css
 wp-includes/blocks/tag-cloud/editor.css
 wp-includes/blocks/tag-cloud/editor.min.css
 wp-includes/build/pages/site-editor/loader.js
 wp-includes/build/pages/site-editor/page-wp-admin.php
 wp-includes/build/pages/site-editor/page.php
 wp-includes/build/routes/font-list/package.json
 wp-includes/build/routes/fonts-home/package.json
 wp-includes/build/routes/home/package.json
 wp-includes/build/routes/index.php
 wp-includes/build/routes/navigation-edit/package.json
 wp-includes/build/routes/navigation-list/package.json
 wp-includes/build/routes/navigation/package.json
 wp-includes/build/routes/pattern-list/package.json
 wp-includes/build/routes/pattern/package.json
 wp-includes/build/routes/post-edit/package.json
 wp-includes/build/routes/post-list/package.json
 wp-includes/build/routes/post-new/package.json
 wp-includes/build/routes/post/package.json
 wp-includes/build/routes/styles/package.json
 wp-includes/build/routes/template-list/package.json
 wp-includes/build/routes/template-part-list/package.json
 wp-includes/build/routes/template-part/package.json
 wp-includes/build/routes/template/package.json
 wp-includes/css/dist/block-library/archives/editor-rtl.css
 wp-includes/css/dist/block-library/archives/editor-rtl.min.css
 wp-includes/css/dist/block-library/archives/editor.css
 wp-includes/css/dist/block-library/archives/editor.min.css
 wp-includes/css/dist/block-library/tabs/editor-rtl.css
 wp-includes/css/dist/block-library/tabs/editor-rtl.min.css
 wp-includes/css/dist/block-library/tabs/editor.css
 wp-includes/css/dist/block-library/tabs/editor.min.css
 wp-includes/css/dist/block-library/tag-cloud/editor-rtl.css
 wp-includes/css/dist/block-library/tag-cloud/editor-rtl.min.css
 wp-includes/css/dist/block-library/tag-cloud/editor.css
 wp-includes/css/dist/block-library/tag-cloud/editor.min.css
 wp-includes/css/dist/index.php
 wp-includes/css/dist/theme/style-rtl.css
 wp-includes/css/dist/theme/style-rtl.min.css
 wp-includes/css/dist/theme/style.css
 wp-includes/css/dist/theme/style.min.css
 wp-includes/js/dist/react-refresh-entry.min.asset.php
 wp-includes/js/dist/react-refresh-entry.min.js
 wp-includes/js/dist/react-refresh-runtime.min.asset.php
 wp-includes/js/dist/react-refresh-runtime.min.js
 wp-includes/js/dist/script-modules/index.php
 }}}

 Here's what I've found so far to confirm that these should have been
 deleted.

 Changes merged in [61605]:
 - The `wp-includes/blocks/archives` and `wp-includes/blocks/tag-cloud` CSS
 files were removed in [https://github.com/WordPress/gutenberg/pull/74255
 GB-74255] and [https://github.com/WordPress/gutenberg/pull/74228
 GB-74228], respectively. These PRs should have also removed the
 corresponding `wp-includes/css/dist/block-library/archives/*.css` and `wp-
 includes/css/dist/block-library/tag-cloud/*.css` files.
 - The `wp-includes/build/pages/site-editor/*` files were removed in
 [https://github.com/WordPress/gutenberg/pull/74221 GB-74221] and the
 directory was renamed to `site-editor-v2` (which does exist as expected).
 - [https://github.com/WordPress/gutenberg/pull/74412/ GB-74412] removed
 the `editor.css` files for the `tabs` block. These were added in [60758]
 were not removed because that came after [61476].

 Other details:
 - I'm unclear how, but I believe that something included in [61492] should
 have removed all of the `package.json` based on the commit message and
 [https://github.com/WordPress/wordpress-
 develop/pull/10718#issuecomment-3754730682 this comment on PR-10718].
 - The `wp-includes/js/dist/react-refersh-*.js` files were removed in
 [61438]. They were re-added in [61488] (and fixed in [61543]), but they
 now reside within `wp-includes/js/dist/development/` instead. I'm also not
 clear on why the move was required. It feels a bit backwards to have a
 "development" file within a `dist` folder, which is meant for
 distribution.

 There are three remaining files that I'm not certain on just yet.
 - The `wp-includes/css/dist/index.php` file was last modified in [61491].
 I have not found where this was removed to confirm it was intentional.
 - `wp-includes/build/routes/index.php`
 - `wp-includes/js/dist/script-modules/index.php`

 I am not 100% sure how to remove these, but without addressing this, they
 will be included in the final package that's generated and shipped to the
 world. This can be confirmed by downloading the nightly or beta2, which
 contains these files.

 It's possible that reverting the `svn:ignore` changes, allow the build
 server to remove the files, then recommitting them could solve the issue.
 I am not going to play around with that right now because I don't want to
 introduce another variable and possibly cause issues with @dmsnell's plan.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64393#comment:176>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform