[wp-trac] [WordPress Trac] #41884: Twenty Seventeen: responsive (gallery) images are too large

[WordPress Trac]

#41884: Twenty Seventeen: responsive (gallery) images are too large
------------------------------------+-----------------------------
 Reporter:  nosilver4u              |       Owner:  (none)
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Bundled Theme           |     Version:  4.8.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+-----------------------------
Changes (by ozgursar):

 * keywords:  has-patch needs-testing dev-feedback => has-patch dev-feedback


Comment:

 == Patch Testing Report

 Patch Tested:
 https://core.trac.wordpress.org/attachment/ticket/41884/41884.diff

 === Environment
 - WordPress: 7.0-alpha-61215-src
 - PHP: 8.2.29
 - Server: nginx/1.29.4
 - Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
 - Browser: Opera
 - OS: macOS
 - Theme: Twenty Seventeen 4.0
 - MU Plugins: None activated
 - Plugins:
   * Classic Editor 1.6.7
   * Test Reports 1.2.1

 === Steps taken
 1. Activate Twenty Seventeen theme and Classic Editor plugin
 2. Go to `Settings` > `Media` and uncheck `Crop thumbnail to exact
 dimensions`
 3. Upload a few images to the media library
 4. Create a post and create a gallery with the uploaded images
 5. Select size as `Thumbnail`
 6. View the post on frontend
 7. Using `Dev Tools`, check the `srcset` and network tab for images
 8. Repeat the same steps for Twenty Sixteen theme and compare the results
 9. ❌ Patch is failing

 === Expected result
 - When `Crop thumbnail to exact dimensions` setting is unchecked in
 `Settings > Media` `srcset` should include only thumbnails.

 === Additional Notes
 - Applying the patch didn't have any affect in my case. I'm adding below
 my test results for the Twenty Sixteen theme as well to show the
 difference.

 === Screenshots/Screencast with results
 Twenty Seventeen Theme

 Before patch:
 [[Image(https://i.imgur.com/hK8pcGc.png)]]

 After patch:
 [[Image(https://i.imgur.com/YtUYGIo.png)]]

 After patch:
 [[Image(https://i.imgur.com/qhQL3Wr.png)]]


 ----

 Twenty Sixteen Theme
 [[Image(https://i.imgur.com/tWo0MoK.png)]]


 [[Image(https://i.imgur.com/6xMLI0h.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41884#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform