[wp-trac] [WordPress Trac] #61175: Integrate PHPStan into the core development workflow

[WordPress Trac]

#61175: Integrate PHPStan into the core development workflow
-------------------------------------------------+-------------------------
 Reporter:  westonruter                          |       Owner:
                                                 |  westonruter
     Type:  task (blessed)                       |      Status:  closed
 Priority:  normal                               |   Milestone:  7.0
Component:  Build/Test Tools                     |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------
Changes (by westonruter):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"61699" 61699]:
 {{{
 #!CommitTicketReference repository="" revision="61699"
 Build/Test Tools: Integrate PHPStan into the core development workflow.

 This change introduces PHPStan static analysis configured at
 [https://phpstan.org/user-guide/rule-levels rule level 0], which includes:
 "basic checks, unknown classes, unknown functions, unknown methods called
 on `$this`, wrong number of arguments passed to those methods and
 functions, always undefined variables". Contributors may elect for a
 higher PHPStan rule level by creating a `phpstan.neon` which overrides
 `phpstan.neon.dist`.

 * Fix various PHPStan level 0 errors by adding `@phpstan-ignore` comments,
 updating PHPDoc types, and adding missing return values.
 * Remove existing `@phpstan-ignore` comments that are now obsolete or
 inapplicable for level 0.
 * Add a new GitHub Actions workflow for PHPStan Static Analysis. Reports
 are currently provided as warnings with inline annotations in pull
 requests and do not fail the build.
 * Add a `phpstan` Grunt task and include it in the `precommit:php` task to
 run before `phpunit`.
 * Introduce a `typecheck:php` npm script and a `composer phpstan` script
 to run analysis in local development environments.
 * Add documentation for PHPStan usage in `tests/phpstan/README.md`.

 Developed in https://github.com/WordPress/wordpress-develop/pull/10419

 Props justlevine, westonruter, johnbillion, desrosj, SirLouen, dmsnell,
 oglekler, joehoyle, jorbin.
 See #64238, #63268, #52217, #51423.
 Fixes #61175.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61175#comment:86>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform