[wp-trac] [WordPress Trac] #60370: Test Tools: Clarifying reusable workflows in Github CI

[WordPress Trac]

#60370: Test Tools: Clarifying reusable workflows in Github CI
------------------------------+----------------------
 Reporter:  youknowriad       |       Owner:  (none)
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:
Component:  Build/Test Tools  |     Version:
 Severity:  minor             |  Resolution:  wontfix
 Keywords:  close             |     Focuses:
------------------------------+----------------------

Comment (by johnbillion):

 Replying to [comment:5 youknowriad]:
 > >  but we don't want to endlessly have to maintain and backport workflow
 changes to 23 old branches.
 >
 > I understand and I agree that it's tedious but IMO we're shooting
 ourselves in the foot by doing so.

 Shooting ourselves in the foot by doing what? Maintaining 23 old branches?
 ''I fully agree'', tell your boss.

 > no one guarantees that an update to Node in trunk would work with the
 npm packages and scripts that were existing in the previous versions.

 This approach is about maintaining the workflow files and keeping them up
 to date so the workflows keep running reliably. The Node version that runs
 scripts is controlled via `.nvmrc` which is present in all branches.
 Updating Node in trunk doesn't affect (or rather, shouldn't affect) old
 branches. Same for Composer dependencies, PHP versions, MySQL versions,
 etc. Some older branches use different workflows, hence the versions in
 some workflow file names (`reusable-phpunit-tests-v3.yml` etc).

 > I wonder if we're overestimating the maintainability benefits here.

 There were at least 27 commits to GitHub Actions during the 6.9 cycle
 alone: #63170. The team who work on these changes through each release
 cycle have decided this is the best approach for maintainability.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60370#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform