[wp-trac] [WordPress Trac] #64656: Fatal error on new font library admin page

[WordPress Trac]

#64656: Fatal error on new font library admin page
----------------------------+--------------------------
 Reporter:  desrosj         |       Owner:  youknowriad
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  7.0
Component:  Administration  |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+--------------------------

Comment (by youknowriad):

 In [changeset:"61679" 61679]:
 {{{
 #!CommitTicketReference repository="" revision="61679"
 Build: Fix Gutenberg build base-url argument passing across platforms.

 When building Gutenberg, the `--base-url` argument was forwarded through
 `npm run build --`, which passes arguments through a shell layer. The
 argument value `includes_url( 'build/' )` contains spaces, parentheses,
 and single quotes that could be mangled by shell parsing on some
 platforms, causing the generated `constants.php` to lose the trailing
 slash in `build_url`.

 This invokes `node bin/build.mjs` directly instead, bypassing npm's
 shell forwarding entirely. The argument is passed as a single array
 element via `spawn`, so it arrives intact regardless of platform.

 Props youknowriad, desrosj.
 See #64656.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64656#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform