[wp-trac] [WordPress Trac] #64393: Change how we include Gutenberg in Core

[WordPress Trac]

#64393: Change how we include Gutenberg in Core
------------------------------+--------------------------
 Reporter:  youknowriad       |       Owner:  youknowriad
     Type:  task (blessed)    |      Status:  reopened
 Priority:  high              |   Milestone:  7.0
Component:  Build/Test Tools  |     Version:
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------------

Comment (by desrosj):

 Did some more testing on this. I decided to just run `npm install -g` for
 every package that gave me an error for the time being because I need to
 get my local environment back up and running. So far I've installed:
 - `patch-package`
 - `husky`
 - `concurrently`
 - `core-js-builder` (was not listed in the `package.json` file for
 Gutenberg, but was in the lock file and the `babel-preset-
 default/package.json` file)
 - `esbuild-esm-loader` (also only specified in the lock Gutenberg file,
 but defined within the `theme/package.json` file)

 I cannot get past `Cannot find module 'core-js-builder'` and `Cannot find
 package 'esbuild-esm-loader'` warnings now, though.


 {{{
 📦 Building workspaces...
 [1] npm run build:php exited with code 0
 [0] npm run build:js exited with code 0


 Command errors:
 node:internal/modules/cjs/loader:1210
   throw err;
   ^

 Error: Cannot find module 'core-js-builder'
 Require stack:
 - /path/to/checkout/wordpress-develop/gutenberg/packages/babel-preset-
 default/bin/index.js
     at Module._resolveFilename (node:internal/modules/cjs/loader:1207:15)
     at Module._load (node:internal/modules/cjs/loader:1038:27)
     at Module.require (node:internal/modules/cjs/loader:1289:19)
     at require (node:internal/modules/helpers:182:18)
     at Object.<anonymous> (/path/to/checkout/wordpress-
 develop/gutenberg/packages/babel-preset-default/bin/index.js:6:17)
     at Module._compile (node:internal/modules/cjs/loader:1521:14)
     at Module._extensions..js (node:internal/modules/cjs/loader:1623:10)
     at Module.load (node:internal/modules/cjs/loader:1266:32)
     at Module._load (node:internal/modules/cjs/loader:1091:12)
     at Function.executeUserEntryPoint [as runMain]
 (node:internal/modules/run_main:164:12) {
   code: 'MODULE_NOT_FOUND',
   requireStack: [
     '/path/to/checkout/wordpress-develop/gutenberg/packages/babel-preset-
 default/bin/index.js'
   ]
 }

 Node.js v20.20.0

 node:internal/modules/esm/resolve:873
   throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
         ^

 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'esbuild-esm-loader'
 imported from /path/to/checkout/wordpress-
 develop/gutenberg/packages/theme/
     at packageResolve (node:internal/modules/esm/resolve:873:9)
     at moduleResolve (node:internal/modules/esm/resolve:946:18)
     at defaultResolve (node:internal/modules/esm/resolve:1188:11)
     at ModuleLoader.defaultResolve
 (node:internal/modules/esm/loader:708:12)
     at #cachedDefaultResolve (node:internal/modules/esm/loader:657:25)
     at ModuleLoader.resolve (node:internal/modules/esm/loader:640:38)
     at ModuleLoader.getModuleJobForImport
 (node:internal/modules/esm/loader:264:38)
     at ModuleLoader.import (node:internal/modules/esm/loader:605:34)
     at asyncRunEntryPointWithESMLoader
 (node:internal/modules/run_main:112:36)
     at runEntryPointWithESMLoader (node:internal/modules/run_main:141:19)
 {
   code: 'ERR_MODULE_NOT_FOUND'
 }

 Node.js v20.20.0


 ❌ Build failed: Command failed: npm run --if-present --workspaces
 --silent build

 ❌ Build failed: npm run build -- --fast --base-url=includes_url( 'build'
 ) failed with code 1

 🔄 Restoring Gutenberg package.json...
 ✅ package.json restored
 ❌ Unexpected error: Error: npm run build -- --fast --base-
 url=includes_url( 'build' ) failed with code 1
     at ChildProcess.<anonymous> (/path/to/checkout/wordpress-
 develop/tools/gutenberg/build-gutenberg.js:66:6)
     at ChildProcess.emit (node:events:524:28)
     at maybeClose (node:internal/child_process:1104:16)
     at Socket.<anonymous> (node:internal/child_process:456:11)
     at Socket.emit (node:events:524:28)
     at Pipe.<anonymous> (node:net:343:12)
 ❌ Sync failed: node tools/gutenberg/build-gutenberg.js failed with code 1
 npm error code 1
 npm error path /path/to/checkout/wordpress-develop
 npm error command failed
 npm error command sh -c npm run gutenberg:sync && npm run gutenberg:copy
 -- --dev
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64393#comment:131>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform