[wp-trac] [WordPress Trac] #64020: Site icon: Don't force cropping

[WordPress Trac]

#64020: Site icon: Don't force cropping
-------------------------------------+-------------------------------------
 Reporter:  jorbin                   |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  7.0
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch dev-feedback   |     Focuses:  javascript,
  changes-requested                  |  administration
-------------------------------------+-------------------------------------

Comment (by ozgursar):

 == Patch Testing Report

 Patch Tested: https://github.com/WordPress/wordpress-develop/pull/10179

 === Environment
 - WordPress: 7.0-alpha-61215-src
 - PHP: 8.2.29
 - Server: nginx/1.29.4
 - Database: mysqli (Server: 8.4.7 / Client: mysqlnd 8.2.29)
 - Browser: Chrome 145.0.0.0
 - OS: macOS
 - Theme: Twenty Twenty-Five 1.4
 - MU Plugins: None activated
 - Plugins:
   * Test Reports 1.2.1

 === Steps taken
 1. Activate any `classic theme`
 2. Appearance > Customize > Site Identity
 3. Click `Select Site Icon`
 4. Upload a square png image that is equal or larger than 512x512 pixels
 5. View `Skip Cropping` and `Crop Image` buttons
 6. Activate `Twenty Twenty-Five` theme
 7. Settings > General Settings > Site Icon
 8. Click `Choose a Site Icon`
 9. Upload a square png image that is equal or larger than 512x512 pixels
 10. Click `Set Site Icon`
 11. View only `Crop Image` button appears
 12. Apply patch and repeat steps 7-10
 13. Confirm that `Crop Image` button does not appear and directly sets the
 site icon
 14. ✅ Patch is solving the problem

 === Expected result
 - After applying the patch, if the image size is properly sized it won't
 ask for cropping the image.

 === Additional Notes
 - Even though the experience is slightly different than `Customize`, I
 think it's better to skip the question `Skip Cropping` or `Crop Image` as
 the aspect ratio will stay the same.

 === Screenshots/Screencast with results
 Video Customize (before patch): https://files.catbox.moe/reugxl.mp4
 Video General Settings (before patch): https://files.catbox.moe/yz8qqc.mp4
 Video General Settings (after patch): https://files.catbox.moe/0j67pe.mp4

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64020#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform