[wp-trac] [WordPress Trac] #41341: Theme update notification appearing multiple times

[WordPress Trac]

#41341: Theme update notification appearing multiple times
-------------------------------------+-------------------------------------
 Reporter:  hardeepasrani            |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Themes                   |     Version:  4.9
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch shiny-       |     Focuses:  javascript,
  updates                            |  administration
-------------------------------------+-------------------------------------

Comment (by Ov3rfly):

 Note: This issue affects every WordPress including 6.9.x, not only Version
 4.9 as stated in issue details. It is and will be reported again and
 again, also because this 9 years old issue has wrong Version tag.

 Took a look at some code.


 `wp.updates.updateThemeSuccess()` in `wp-admin/js/updates.js` at about
 line 1600 tries to figure out the selector of target element for the
 update message.

 It uses `$notice = $( '.theme-info .notice' )` and obviously gets the
 element(s) in currently shown context, no matter if or which theme details
 currently are shown.

 The actually updated theme slug would be available in `response.slug` but
 the DOM of theme details appears to not have the slug anywhere - or maybe
 I missed it.

 So the suggested fix would be:
 * add theme slug to DOM of each theme details
 * use `response.slug` to find target element for the update message
 * make sure only one `.theme-info .notice` is in theme details or use more
 specific selector to avoid showing message multiple times

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41341#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform