[wp-trac] [WordPress Trac] #64280: Unable to change the lightbox settings of the Image block within Global Styles when KSES is active

[WordPress Trac]

#64280: Unable to change the lightbox settings of the Image block within Global
Styles when KSES is active
-------------------------------------------------+-------------------------
 Reporter:  ramonopoly                           |       Owner:  ramonopoly
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  7.0
Component:  Themes                               |     Version:  6.4
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests gutenberg-  |     Focuses:
  merge                                          |
-------------------------------------------------+-------------------------
Changes (by ramonopoly):

 * owner:  (none) => ramonopoly
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"61618" 61618]:
 {{{
 #!CommitTicketReference repository="" revision="61618"
 WP_Theme_JSON: preserve valid non-preset settings for lightbox when KSES
 filters are active

 Extends `VALID_SETTINGS` entries to also do type validation (as well as
 schema key validation) for the lightbox settings only.

 Previously, when KSES filters were active (via `add_action( 'init',
 'kses_init_filters' )`), valid non-preset settings in Global Styles were
 being incorrectly filtered out. For example, `lightbox.enabled` and
 `lightbox.allowEditing` for Image blocks.

 The idea is that `VALID_SETTINGS` values can act as type validation for
 further valid settings.

 Props ramonopoly, mmtr86, oandregal, wildworks, westonruter, andrewserong.

 Fixes #64280.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64280#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform