[wp-trac] [WordPress Trac] #63980: Set featured image button incorrectly coded as link and missing required ARIA attributes

[WordPress Trac]

#63980: Set featured image button incorrectly coded as link and missing required
ARIA attributes
--------------------------------------------+------------------------------
 Reporter:  alh0319                         |       Owner:  joedolson
     Type:  defect (bug)                    |      Status:  closed
 Priority:  normal                          |   Milestone:  7.0
Component:  Editor                          |     Version:
 Severity:  normal                          |  Resolution:  fixed
 Keywords:  has-patch has-test-info commit  |     Focuses:  ui,
                                            |  accessibility
--------------------------------------------+------------------------------
Changes (by joedolson):

 * owner:  (none) => joedolson
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"61616" 61616]:
 {{{
 #!CommitTicketReference repository="" revision="61616"
 Editor: A11y: Fix featured image control naming.

 The controls to set and remove a featured image in the Classic Editor use
 a link with no attributes to identify purpose. Triggering a modal dialog
 should be done using a button with proper identification.

 Add `role="button"`, `aria-haspopup="dialog"`, and `aria-controls`
 attributes to give users appropriate information about the control
 behavior. Add keypress handlers for button-specific keyboard events.

 Does not use a `button` element to avoid interfering with style
 customizations.

 Props alh0319, joedolson, mukesh27, huzaifaalmesbah.
 Fixes #63980.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63980#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform