[wp-trac] [WordPress Trac] #64599: Harden handling of PHP superglobals to prevent notices and potential data integrity issues

[WordPress Trac]

#64599: Harden handling of PHP superglobals to prevent notices and potential data
integrity issues
-----------------------------------------+--------------------------
 Reporter:  vishalkakadiya               |       Owner:  westonruter
     Type:  defect (bug)                 |      Status:  closed
 Priority:  normal                       |   Milestone:  7.0
Component:  Site Health                  |     Version:
 Severity:  normal                       |  Resolution:  fixed
 Keywords:  has-patch changes-requested  |     Focuses:
-----------------------------------------+--------------------------

Comment (by johnbillion):

 I think it's fine for this change to stay in now that it's in, and
 defensive programming certainly has value, but inventing hypothetical
 situations or configuration that's not actually seen in the wild isn't a
 great use of time when there are
 [https://core.trac.wordpress.org/query?status=accepted&status=assigned&status=new&status=reopened&status=reviewing&order=priority
 8,000 open tickets] that are better deserving of time from contributors.

 Just something to bear in mind for the future. We don't need to work on
 hypothetical bugs when real ones remain unaddressed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64599#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform