[wp-trac] [WordPress Trac] #64610: Direct filesystem chmod emits warnings even if the permissions already match

[WordPress Trac]

#64610: Direct filesystem chmod emits warnings even if the permissions already
match
----------------------------+-----------------------------
 Reporter:  redsweater      |       Owner:  SergeyBiryukov
     Type:  defect (bug)    |      Status:  accepted
 Priority:  normal          |   Milestone:  7.0
Component:  Filesystem API  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * owner:  (none) => SergeyBiryukov
 * status:  new => accepted
 * component:  General => Filesystem API
 * milestone:  Awaiting Review => 7.0


Comment:

 Hi there, thanks for the PR!

 Replying to [comment:2 redsweater]:
 > I am a little naive about PHP, so I approached this by trying to avoid
 calling chmod, the function that ultimately issues the warning. But I have
 since learned about @ for suppressing warnings, and maybe simply adding @
 to the chmod call would be suitable?

 That would not be the preferred approach here, as it would go against the
 WordPress Coding Standards, see [45611].

 I think we can go ahead with the proposed PR, moving for 7.0
 consideration.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64610#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform