[wp-trac] [WordPress Trac] #65129: Improve maintainability of DOCTYPE quirks mode detection in `WP_HTML_Doctype_Info` class

[WordPress Trac]

#65129: Improve maintainability of DOCTYPE quirks mode detection in
`WP_HTML_Doctype_Info` class
-------------------------------------------+-------------------------------
 Reporter:  baikare.sandeep007             |       Owner:  (none)
     Type:  enhancement                    |      Status:  new
 Priority:  normal                         |   Milestone:  Awaiting Review
Component:  HTML API                       |     Version:  6.7
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch needs-testing close  |     Focuses:  coding-standards
-------------------------------------------+-------------------------------
Changes (by jonsurrell):

 * keywords:  has-patch needs-testing => has-patch needs-testing close


Comment:

 Hi @baikaresandeep007, thanks for your interest in the HTML API and this
 contribution!

 These seems to be a refactor with no intentional behavior changes. The
 arguments in favor of this refactor are fairly subjective and I don't
 think change meets the
 [https://make.wordpress.org/core/handbook/contribute/code-refactoring/
 guidelines around refactoring]. The performance impact is unclear and the
 PR notes that this is unlikely to be a hotspot. The impact on
 maintainability of this block also seems highly subjective.

 I'll recommend this for closure but leave it open for feedback or other
 opinions.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/65129#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform