[wp-trac] [WordPress Trac] #64393: Change how we include Gutenberg in Core

[WordPress Trac]

#64393: Change how we include Gutenberg in Core
------------------------------+--------------------------
 Reporter:  youknowriad       |       Owner:  youknowriad
     Type:  task (blessed)    |      Status:  closed
 Priority:  high              |   Milestone:  7.0
Component:  Build/Test Tools  |     Version:
 Severity:  blocker           |  Resolution:  fixed
 Keywords:  has-patch         |     Focuses:
------------------------------+--------------------------

Comment (by davidbaumwald):

 Ran into something similar today when running `npm run build` on `trunk`.
 In Windows, when `gutenberg:download` is called and `tar` tries to
 extract, the path is invalid:

 {{{
 📥 Downloading and extracting artifact...
 tar: F\:\\WordPress Core
 Develop\\develop.svn.wordpress.org\trunk\\gutenberg: Cannot open: No such
 file or directory
 tar: Error is not recoverable: exiting now
 ❌ Download/extraction failed: write EPIPE
 }}}

 So, in my case using Git Bash/MSYS2 any path with a colon is treated as a
 network path, so it's adding the double slash.

 I asked Claude, and it seems the tar args can be tweaked to swap out `-C`
 with `cwd`.  This is [https://github.com/WordPress/wordpress-
 develop/blob/trunk/tools/gutenberg/download.js#L116
 tools/gutenberg/download.js line 119]:
 {{{
 const tar = spawn( 'tar', [ '-x' ], {
     cwd: gutenbergDir,
     stdio: [ 'pipe', 'inherit', 'inherit' ],
 } );
 }}}

 After this change was applied, the `gutenberg:verify` task completed
 successfully and the build proceeded.  Unsure how this change affects
 other envs.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64393#comment:255>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform