[wp-trac] [WordPress Trac] #65098: get_site_icon_url() returns empty string even when fallback is defined, breaking wp-embed-site-icon in the_embed_site_title()

[WordPress Trac]

#65098: get_site_icon_url() returns empty string even when fallback is defined,
breaking wp-embed-site-icon in the_embed_site_title()
--------------------------+---------------------
 Reporter:  pontocinza    |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  7.1
Component:  Embeds        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+---------------------

Comment (by mohamedahamed):

 Yes, the defensive checks needs to be added in Core, namely:
 1. In get_site_icon_url() (general-template.php): Only update $url if the
 attachment URL is not empty

 2. In the_embed_site_title() (embed.php): Check if URL is empty before
 rendering the img tag (like wp_site_icon() already does).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/65098#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform