[wp-trac] [WordPress Trac] #65079: block_core_navigation_get_inner_blocks_from_unstable_location() calls deprecated function; deprecated docblock references non-existent replacement

[WordPress Trac]

#65079: block_core_navigation_get_inner_blocks_from_unstable_location() calls
deprecated function; deprecated   docblock references non-existent
replacement
-------------------------------------+-------------------------------------
 Reporter:  saratheonline            |       Owner:  saratheonline
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Editor                   |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  docs, coding-standards
-------------------------------------+-------------------------------------

Comment (by saratheonline):

 Replying to [comment:1 wildworks]:
 > @saratheonline Thanks for submitting a patch.
 >
 > The `navigation.php` file cannot be directly edited in the WordPress
 core. This file is synced from the Gutenberg repository.
 >
 > See:
 https://github.com/WordPress/gutenberg/blob/7563e2acf2a8bcfbe6338ca4bd5cc0d7eed74535/packages
 /block-library/src/navigation/index.php#L1601
 >
 > Would it be possible for you to submit a new PR to
 [https://github.com/WordPress/gutenberg the Gutenberg repository]?



 \\Thanks for the pointer! I've confirmed the bug exists in the Gutenberg
 source at packages/block-library/src/navigation/index.php and have moved
 the fix upstream.
   - Gutenberg issue: https://github.com/WordPress/gutenberg/issues/77442
   - Gutenberg PR: https://github.com/WordPress/gutenberg/pull/77445
 \\The PR addresses all three issues:
   1. block_core_navigation_get_inner_blocks_from_unstable_location() no
 longer calls the deprecated
 block_core_navigation_parse_blocks_from_menu_items() — a new private
 helper block_core_navigation_convert_menu_items_to_blocks() holds the
 actual logic.
   2. The missing ?? array() guard on $menu_items_by_parent_id[0] is added.
   3. The @deprecated docblock is corrected to reference
 WP_Classic_To_Block_Menu_Converter::to_blocks().

 This ticket can be closed or marked as a duplicate/upstream once the
 Gutenberg PR is merged and synced to Core.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/65079#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform