[wp-trac] [WordPress Trac] #63962: PHP 8.5: Fix deprecation notices for __sleep and __wakeup magic methods

[WordPress Trac]

#63962: PHP 8.5: Fix deprecation notices for __sleep and __wakeup magic methods
-------------------------------------------+-------------------------------
 Reporter:  TobiasBg                       |       Owner:  SergeyBiryukov
     Type:  defect (bug)                   |      Status:  reopened
 Priority:  normal                         |   Milestone:  6.9
Component:  General                        |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  php85 has-patch needs-testing  |     Focuses:  php-
                                           |  compatibility
-------------------------------------------+-------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:11 desrosj]:
 > In classes where actual logic was moved into `__unserialize()` (this
 should not matter for any that throw a `LogicException` should), the logic
 needs to be updated to restore the passed data from the `$data` parameter
 before performing checks for the presence or datatype of the expected
 properties.

 Thanks! [https://github.com/WordPress/wordpress-develop/pull/10031 PR
 10031] fixes the issue in my testing, though the tests on GitHub appear to
 be failing currently due to some unrelated issue:
 {{{
 > WordPress at 6.9.0 env:start
 > node ./tools/local-env/scripts/start.js && node ./tools/local-
 env/scripts/docker.js run -T --rm php composer update -W

  wordpress-develop Pulling
  php Pulling
  cli Pulling
  mysql Pulling
  cli Error unauthorized: authentication required
  wordpress-develop  Interrupted
  mysql  Interrupted
  php  Interrupted
 Error response from daemon: unauthorized: authentication required
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63962#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform