[wp-trac] [WordPress Trac] #64010: wp_die() status code Media component updates (parent ticket: #64009)

[WordPress Trac]

#64010: wp_die() status code Media component updates (parent ticket: #64009)
--------------------------+-----------------------------
 Reporter:  callumbw95    |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Media         |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:                |
--------------------------+-----------------------------
 If you have come here directly, please refer back to the parent ticket
 here: [https://core.trac.wordpress.org/ticket/64009 #64009]

 This ticket is regarding the `wp_die()` function calls within the Media
 component and will cover the following locations:

 || Filepath || Line Number || Context || Status Code || New Code || Code
 Meaning ||
 || src/wp-admin/includes/class-file-upload-upgrader.php ||
 [https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 admin/themes.php#L57 57] || REQUEST: invalid params || 500 || 400 || Bad
 Request ||
 || src/wp-admin/includes/claass-file-upload-upgrader.php ||
 [https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 admin/themes.php#L82 82] || UPLOAD: Invalid file || 500 || 422 ||
 Unprocessable Content ||
 || src/wp-admin/includes/class-file-upload-upgrader.php ||
 [https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 admin/themes.php#L91 91] || UPLOAD: Invalid file || 500 || 422 ||
 Unprocessable Content ||
 || src/wp-admin/includes/class-file-upload-upgrader.php ||
 [https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 admin/themes.php#L120 120] || UPLOAD: missing file || 500 || 400 || Bad
 Request ||
 || src/wp-admin/includes/class-file-upload-upgrader.php ||
 [https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 admin/themes.php#L136 136] || UPLOAD: missing file || 500 || 400 || Bad
 Request ||
 || src/wp-admin/async-upload.php || [https://github.com/WordPress
 /wordpress-develop/blob/trunk/src/wp-admin/themes.php#L35 35] || User
 Permissions: does not have access || 500 || 403 || Forbidden ||
 || src/wp-admin/async-upload.php || [https://github.com/WordPress
 /wordpress-develop/blob/trunk/src/wp-admin/themes.php#L43 43] || Error:
 invalid post type || 500 || 400 || Bad Request ||
 || src/wp-admin/media-new.php || [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-admin/themes.php#L16 16] || User Permissions:
 does not have access || 500 || 403 || Forbidden ||
 || src/wp-admin/upload.php || [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-admin/themes.php#L13 13] || User Permissions:
 does not have access || 500 || 403 || Forbidden ||
 || src/wp-admin/upload.php || [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-admin/themes.php#L296 296] || User Permissions:
 does not have access || 500 || 403 || Forbidden ||
 || src/wp-admin/upload.php || [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-admin/themes.php#L317 317] || User Permissions:
 does not have access || 500 || 403 || Forbidden ||
 || src/wp-admin/upload.php || [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-admin/themes.php#L332 332] || User Permissions:
 does not have access || 500 || 403 || Forbidden ||

 There are however the following function calls I have not touched as I
 felt they were already valid with their current status code:

 || Filepath || Line Number || Status Code ||
 || src/wp-admin/includes/class-file-upload-upgrader.php ||
 [https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 admin/includes/class-file-upload-upgrader.php#L69 69] || 500 ||
 || src/wp-admin/includes/class-file-upload-upgrader.php ||
 [https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-
 admin/includes/class-file-upload-upgrader.php#L129 129] || 500 ||
 || src/wp-admin/media-new.php || [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-admin/media-new.php#L35 35] || 500 ||
 || src/wp-admin/media-upload.php || [https://github.com/WordPress
 /wordpress-develop/blob/trunk/src/wp-admin/media-upload.php#L30 30] || 403
 ||
 || src/wp-admin/media-upload.php || [https://github.com/WordPress
 /wordpress-develop/blob/trunk/src/wp-admin/media-upload.php#L37 37] || 403
 ||
 || src/wp-admin/media-upload.php || [https://github.com/WordPress
 /wordpress-develop/blob/trunk/src/wp-admin/media-upload.php#L45 45] || 403
 ||
 || src/wp-admin/upload.php || [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-admin/upload.php#L300 300] || 500 ||
 || src/wp-admin/upload.php || [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-admin/upload.php#L321 321] || 500 ||
 || src/wp-admin/upload.php || [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/wp-admin/upload.php#L336 336] || 500 ||

 Please have a look through the suggested changes documented here, and
 any/all feedback is appreciated. 😃

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64010>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform