[wp-trac] [WordPress Trac] #63268: PHPStan code quality improvements for 6.9

[WordPress Trac]

#63268: PHPStan code quality improvements for 6.9
----------------------------+-------------------------------
 Reporter:  justlevine      |       Owner:  SergeyBiryukov
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  6.9
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by SirLouen):

 Replying to [comment:180 justlevine]:
 > @SirLouen the original intention for this ticket was specifically to
 remediate PHPStan violations, in order to reduce the friction (via
 errors/baselines) needed to adopt PHPStan
 (https://core.trac.wordpress.org/ticket/61175), as well as track progress
 and the impact of using that tool to bolster the justifications in favor
 of adopting it.

 Maybe a specific task should be set for this purpose. I have not fully set
 up the PHPStan with the baseline you added yet for my regular triage. But
 as I commented the other day, I don't even know if with this level, errors
 that are being spotted in the wild, would have been also spotted by
 PHPStan.

 But we cannot restrict this to PHPStan violations, because they are
 strictly of the same nature. I don't agree that PHPStan violations are
 easier to triage (in fact we can be introducing bugs if we triage them too
 optimistically). They have to be triaged with the same carefulness as any
 other. Because PHPStan can miss more than a funfair shotgun.

 > To be unnecessarily pedantic, PHPCS is a _linting_ tool and not static
 analysis 😅 but still I think there too, it's the virtue of it being a
 tool with a specific ruleset + violation list that allows for relatively
 efficient triage.

 PS: It appears that they don't agree. 🙊

 [[Image(https://i.imgur.com/b38T8Zv.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63268#comment:181>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform