[wp-trac] [WordPress Trac] #63711: Adopt standard get_temp_dir() in Text_Diff

[WordPress Trac]

#63711: Adopt standard get_temp_dir() in Text_Diff
--------------------------------+-----------------------------
 Reporter:  TimoTijhof          |       Owner:  SergeyBiryukov
     Type:  enhancement         |      Status:  closed
 Priority:  normal              |   Milestone:  6.9
Component:  External Libraries  |     Version:  trunk
 Severity:  minor               |  Resolution:  fixed
 Keywords:  has-patch           |     Focuses:
--------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"60777" 60777]:
 {{{
 #!CommitTicketReference repository="" revision="60777"
 External Libraries: Adopt standard `get_temp_dir()` in
 `Text_Diff::_getTempDir()`.

 This aims to bring more consistency with the rest of core, and more
 closely mirrors the similar changes upstream to use `sys_get_temp_dir()`.

 The potential `false` return value was not checked by the only caller in
 `Text_Diff_Engine_shell::diff()`.

 Follow-up to [7747], [48464], [49185], [60776].

 Props TimoTijhof, apermo, SergeyBiryukov.
 Fixes #63711.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63711#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform