[wp-trac] [WordPress Trac] #53323: Place Hello Dolly in containing folder

[WordPress Trac]

#53323: Place Hello Dolly in containing folder
-------------------------------------------------+-------------------------
 Reporter:  afragen                              |       Owner:  whyisjake
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.9
Component:  Upgrade/Install                      |     Version:  5.8
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests reporter-   |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by dd32):

 `get_option()` should have a default of an empty array here, to account
 for Multisite networks where an individual site doesn't have plugins
 active.

 {{{
 E_ERROR: Uncaught TypeError: array_search(): Argument #2 ($haystack) must
 be of type array, string given in wp-admin/includes/upgrade.php:2504

 Stack trace:
 #0 wp-admin/includes/upgrade.php(2504): array_search('hello.php', '',
 true)
 #1 wp-admin/includes/upgrade.php(890): upgrade_690()
 #2 wp-admin/includes/upgrade.php(678): upgrade_all()
 #3 wp-admin/upgrade.php(166): wp_upgrade()
 #4 {main}
  thrown
 Source: GET https://example.org/wp-admin/upgrade.php?step=1
 }}}

 FYI @SergeyBiryukov

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53323#comment:93>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform