[wp-trac] [WordPress Trac] #64080: WP_Upgrader doesn't release lock on create_lock

[WordPress Trac]

#64080: WP_Upgrader doesn't release lock on create_lock
-------------------------------+-----------------------
 Reporter:  skithund           |       Owner:  skithund
     Type:  defect (bug)       |      Status:  assigned
 Priority:  normal             |   Milestone:  6.9
Component:  Upgrade/Install    |     Version:  4.5
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+-----------------------

Comment (by skithund):

 And then there's the question, why is there a `INSERT IGNORE` used in
 `WP_Upgrader::create_lock()` and
 [https://github.com/search?q=repo%3AWordPress%2Fwordpress-
 develop+path%3A%22src%22+%22insert+ignore%22&type=code four other places
 duplicating identical code] instead of using Options API to interact with
 options, since the lock is "just an option"?

 To avoid unnecessary database queries or just old/duplicated code from way
 back when the Options API wasn't available?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64080#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform