[wp-trac] [WordPress Trac] #62128: Twenty Thirteen to Twenty Sixteen: update Genericons

[WordPress Trac]

#62128: Twenty Thirteen to Twenty Sixteen: update Genericons
---------------------------+--------------------------
 Reporter:  sabernhardt    |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  6.9
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  performance
---------------------------+--------------------------

Comment (by sabernhardt):

 I missed the version string in `twentythirteen_custom_header_fonts()`,
 which is now part of the patch.

 I also agree about removing the `-webkit-min-device-pixel-ratio` hack from
 Twenty Fifteen and Twenty Sixteen. That apparently was for
 [https://stackoverflow.com/questions/15422770/font-face-svg-not-working-
 properly-in-chrome#answer-19247378 Chrome on Windows] until Chrome 38
 dropped [https://caniuse.com/svg-fonts support for SVG fonts].

 Additional steps are more questionable for this ticket, especially since
 the cycle is now in beta.
 1. Remove the TTF and SVG `src` references. [https://caniuse.com/mdn-
 css_at-rules_font-face_woff WOFF support] seems good enough now.
 2. Remove all prefixes from `transform` in the rotate and flip classes
 (Twenty Sixteen). In admin styles, [41062] removed `-ms-transform`, and
 [43309] removed `-webkit-transform`.
 3. The `transition` prefixes probably should stay as they are for anyone
 who overruled them, but the second time value is missing a unit. The first
 time could have a leading zero too: \\`-moz-transition: color 0.1s ease-in
 0s;`
 4. Remove `speak: never` and add the empty alternative `content` values
 for each `genericon-` class, as [60885] did.
 5. Update the themes' `style.css` values for `content` and `speak`
 properties. (This probably should be done, on a separate ticket.)

 I theoretically could copy the final modified stylesheet from Twenty
 Sixteen to use //nearly// the same file for all four themes, but Twenty
 Thirteen and Twenty Fourteen should continue to set `width` and `height`
 at 16px. And I'm not sure what other adjustments those two themes might
 need with that change.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/62128#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform