[wp-trac] [WordPress Trac] #64145: Notes should not appear in the context of comments

[WordPress Trac]

#64145: Notes should not appear in the context of comments
-----------------------------+-------------------------
 Reporter:  adamsilverstein  |      Owner:  (none)
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  6.9
Component:  Editor           |    Version:  trunk
 Severity:  normal           |   Keywords:  needs-patch
  Focuses:                   |
-----------------------------+-------------------------
 Notes should never appear in the context of regular (front end) comments.
 Although they share the same comments table, notes use a specific "note"
 comment type. Notes of this type need to be consistently excluded wherever
 comments or comment counts are shown.

 Related reports in the Gutenberg repository:
 - Showing in recent comments widget:
 https://github.com/WordPress/gutenberg/issues/72607
 - Showing in "Mine" count:
 https://github.com/WordPress/gutenberg/issues/72548


 Feedback from @mamaduka:

 > This happens only in WP 6.9 Beta when the Gutenberg plugin is not
 active. To reproduce the same issue with Gutenberg, you'll need to remove
 the exclude_block_comments_from_admin filter. During the core sync, it was
 decided not to use a similar filter and modify the admin comment list
 queries directly.

 > Problem
 > The Comment Query's default value for type is an empty string,
 [https://github.com/WordPress/wordpress-
 develop/blob/97382397b2bd7c85aef6d4cd1c10bafd397957fc/src/wp-includes
 /class-wp-comment-query.php#L780-L784 which means all types are returned].
 We'll have to modify this logic in a backward-compatible manner, maybe
 giving it a different meaning - all types except note.

 > Unfortunately, I'm not sure what the best way to do it is. Hardcode it,
 use a filter like we do in Gutenberg, or something else.


 From @jeffpaul:

 > Note that this was also reported in https://wordpress.org/support/topic
 /showing-new-notes-under-recent-comments-in-dashboard-is-
 tricky/#post-18691377.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64145>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform