[wp-trac] [WordPress Trac] #64102: add label to date/time to show which string is the language default

[WordPress Trac]

#64102: add label to date/time to show which string is the language default
-----------------------------------+-----------------------------
 Reporter:  pbearne                |       Owner:  SergeyBiryukov
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  6.9
Component:  Date/Time              |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:4 swissspidy]:
 > won't `__( 'F j, Y' )` and `__( 'g:i a' )` actually be displayed in the
 user locale though? So saying it's the site language default is incorrect.
 Unless I'm missing something, we'd need to switch locales first.

 Good point, thanks!

 Replying to [comment:5 johnbillion]:
 > What is the underlying intention of this change?

 I thought it might be beneficial to see which value is the default
 date/time format for the locale, but I missed that site locale might be
 different from the user's locale.

 Perhaps the label could be just "Language default" to keep things simple?
 Otherwise, this can be reverted for now.

 > This doesn't appear to be compatible with RTL languages. It's
 concatenating two localised strings together.

 As far as I can tell, that should not be an issue for RTL languages. There
 are many other instances where we concatenate localized strings together,
 including help text on that very screen, or constructing
 `$pending_admin_email_message`. Text direction would then take care of
 proper display, as noted in #47655, #55081, etc.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64102#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform