[wp-trac] [WordPress Trac] #63709: Twenty Twelve: version 4.6 adds CRLF line endings on every file

[WordPress Trac]

#63709: Twenty Twelve: version 4.6 adds CRLF line endings on every file
---------------------------------------------+------------------------
 Reporter:  pfg                              |       Owner:  monikarao
     Type:  defect (bug)                     |      Status:  reopened
 Priority:  normal                           |   Milestone:  6.8.4
Component:  Bundled Theme                    |     Version:  6.8.2
 Severity:  minor                            |  Resolution:
 Keywords:  has-test-info close 2nd-opinion  |     Focuses:
---------------------------------------------+------------------------

Comment (by riccardodicurti):

 I noticed the full diff across all files between versions:

 --- twentytwelve-4.5/twentytwelve
 +++ twentytwelve-4.6/twentytwelve


 After applying the patch 63709.diff to 4.6 and comparing again with
 version 4.5, I still see all the differences caused by the conversion from
 Unix-style LF to DOS-style CRLF.

 Here are my steps for reference:

 diff -ru wordpress-develop/src/wp-content/themes/twentytwelve
 twentytwelve-4.5/twentytwelve > diff4.txt
 # → Diff on every file

 diff -ru wordpress-develop/src/wp-content/themes/twentytwelve
 twentytwelve-4.6/twentytwelve > diff5.txt
 # → No diff

 patch < 63709.diff

 diff -ru wordpress-develop/src/wp-content/themes/twentytwelve
 twentytwelve-4.6/twentytwelve > diff6.txt
 # → Version diff as expected from the patch


 However, comparing again with 4.5:

 diff -ru wordpress-develop/src/wp-content/themes/twentytwelve
 twentytwelve-4.5/twentytwelve > diff7.txt


 I still get all the line-ending differences.

 @monikarao could you please confirm if I’m missing a step?

 I was expecting the patch to revert the CRLF conversion, restoring the
 original LF endings and leaving only the intended version changes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63709#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform